-
-
Notifications
You must be signed in to change notification settings - Fork 362
Level 0 Builders = No Decorating #10938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Prevent level 0 builders from auto-assigning themselves decoration, or from being assigned to the decoration from the build confirmation drop-down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this prevent building the builder as well?
No, I was still able to call for a build on the Level 0 hut by the builder (although a level 0 builder can build someone else's level 0 hut, which afaik is always how it has been, and fine?). Because the changes are to the subclasses specific to Decoration (WindowBuildDecoration and WorkOrderDecoration) I think "regular" buildings should be unaffected (and seemed to be unaffected, with the level 0 building hut test mentioned previously). It's possible I'm missing a side-effect to test for, but I can't think what! |
Ah, I didn't see the class name, fair enough. |
No, please don't do that! Using a level 0 for deco has never hurt anything, and is super handy in some situations! (underground and underwater for example, to get a "shell" built for their actual hut to go into!) |
I don't know if I'm allowed to comment here. I suppose this will be a test. 🙂 I understand not allowing the builder to auto assign him/herself to the deco, since most players will wish to have them build their hut first. Why not still allow them to build the deco if you assign it to them manually? |
That turned out to be a bug and not intended behaviour |
We were aware of this. It was just not on our priority list yet =D |
Level 0 Builders = No Decorating
Noooo please no, Bug or no bug this has been around since day dot and has become an integral part of the game. May be broken in your eyes but in players, it works perfectly fine. |
Closes #10937
Changes proposed in this pull request
Testing
Review please