8000 Level 0 Builders = No Decorating by armele · Pull Request #10938 · ldtteam/minecolonies · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Level 0 Builders = No Decorating #10938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2025
Merged

Conversation

armele
Copy link
Contributor
@armele armele commented Jun 10, 2025

Closes #10937

Changes proposed in this pull request

  • Prevent level 0 builders from auto-assigning themselves decoration, or from being assigned to the decoration from the build confirmation drop-down.

Testing

  • Yes I tested this before submitting it.
  • [No] I also did a multiplayer test.

Review please

Prevent level 0 builders from auto-assigning themselves decoration, or from being assigned to the decoration from the build confirmation drop-down.
Copy link
Contributor
@Raycoms Raycoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this prevent building the builder as well?

@armele
Copy link
Contributor Author
armele commented Jun 10, 2025

No, I was still able to call for a build on the Level 0 hut by the builder (although a level 0 builder can build someone else's level 0 hut, which afaik is always how it has been, and fine?).

Because the changes are to the subclasses specific to Decoration (WindowBuildDecoration and WorkOrderDecoration) I think "regular" buildings should be unaffected (and seemed to be unaffected, with the level 0 building hut test mentioned previously).

It's possible I'm missing a side-effect to test for, but I can't think what!

@Raycoms
Copy link
Contributor
Raycoms commented Jun 10, 2025

No, I was still able to call for a build on the Level 0 hut by the builder (although a level 0 builder can build someone else's level 0 hut, which afaik is always how it has been, and fine?).

Because the changes are to the subclasses specific to Decoration (WindowBuildDecoration and WorkOrderDecoration) I think "regular" buildings should be unaffected (and seemed to be unaffected, with the level 0 building hut test mentioned previously).

It's possible I'm missing a side-effect to test for, but I can't think what!

Ah, I didn't see the class name, fair enough.

@Talyda
Copy link
Contributor
Talyda commented Jun 10, 2025

No, please don't do that!

Using a level 0 for deco has never hurt anything, and is super handy in some situations! (underground and underwater for example, to get a "shell" built for their actual hut to go into!)

@AliahMC
Copy link
AliahMC commented Jun 11, 2025

I don't know if I'm allowed to comment here. I suppose this will be a test. 🙂

I understand not allowing the builder to auto assign him/herself to the deco, since most players will wish to have them build their hut first. Why not still allow them to build the deco if you assign it to them manually?

@MotionlessTrain
Copy link
Contributor
MotionlessTrain commented Jun 11, 2025

That turned out to be a bug and not intended behaviour
It’s just that nobody reported it until now, and so the devs were unaware that this was possible

@Raycoms
Copy link
Contributor
Raycoms commented Jun 11, 2025

That turned out to be a bug and not intended behaviour It’s just that nobody reported it until now, and so the devs were unaware that this was possible

We were aware of this. It was just not on our priority list yet =D

@Raycoms Raycoms merged commit a7750fb into ldtteam:version/main Jun 15, 2025
5 checks passed
Raycoms pushed a commit that referenced this pull request Jun 15, 2025
Level 0 Builders = No Decorating
@Khallie
Copy link
Khallie commented Jun 15, 2025

Noooo please no, Bug or no bug this has been around since day dot and has become an integral part of the game. May be broken in your eyes but in players, it works perfectly fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder starts building deco instead of his hut
7 participants
0