8000 Fix Farmer Reporting Missing Equipment After Completing All Field Work by rivon0507 · Pull Request #10956 · ldtteam/minecolonies · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Farmer Reporting Missing Equipment After Completing All Field Work #10956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: version/main
Choose a base branch
from
Draft

Fix Farmer Reporting Missing Equipment After Completing All Field Work #10956

wants to merge 1 commit into from

Conversation

rivon0507
Copy link

Closes #10911

Changes proposed in this pull request

  • Having no more fields to work on does not mean the farmer is idle at their job : they're not missing anything, just done with the day's field work
  • logging has been introduced to capture cases where the AI encounters unexpected extensions. This should help in monitoring potential data inconsistencies that may not yet cause failures but are still worth tracking

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

@rivon0507
Add check for null field and log unexpected extensions in farmer AI
d210714 
`fieldToWork` being `null` means the farmer has no more field work left for the day, so they can stay idle listening for crafting requests.
@CLAassistant
Copy link
CLAassistant commented Jun 17, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rivon0507 rivon0507 changed the title Add check for null field and log unexpected extensions in farmer AI Fix Farmer Reporting Missing Equipment After Completing All Field Work Jun 17, 2025
@rivon0507 rivon0507 closed this Jun 17, 2025
@rivon0507 rivon0507 reopened this Jun 17, 2025
@rivon0507 rivon0507 marked this pull request as draft June 17, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Farmers "Waiting for something"
2 participants
@rivon0507 @CLAassistant
0