8000 chore: deprecate some `Int.ofNat_*` lemmas by TwoFX · Pull Request #8000 · leanprover/lean4 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: deprecate some Int.ofNat_* lemmas #8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

chore: deprecate some Int.ofNat_* lemmas #8000

merged 3 commits into from
Apr 25, 2025

Conversation

TwoFX
Copy link
Member
@TwoFX TwoFX commented Apr 17, 2025

This PR deprecates some Int.ofNat_* lemmas in favor of Int.natCast_*.

@TwoFX TwoFX added the changelog-library Library label Apr 17, 2025
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 17, 2025 12:20 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 17, 2025
@leanprover-community-bot
Copy link
Collaborator
leanprover-community-bot commented Apr 17, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 85f5a81f170105b3e45a17007db5a9cb91646122 --onto 020b8834c3e06da1cd1682431b6fa8d52206c8ec. You can force Mathlib CI using the force-mathlib-ci label. (2025-04-17 12:26:31)
  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2025-04-22 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2025-04-22 13:17:57)
  • 🟡 Mathlib branch lean-pr-testing-8000 build against this PR was cancelled. (2025-04-25 14:19:25) View Log
  • 🟡 Mathlib branch lean-pr-testing-8000 build against this PR was cancelled. (2025-04-25 14:30:43) View Log
  • 🟡 Mathlib branch lean-pr-testing-8000 build against this PR was cancelled. (2025-04-25 15:04:37) View Log
  • 💥 Mathlib branch lean-pr-testing-8000 build failed against this PR. (2025-04-25 15:44:24) View Log
  • ✅ Mathlib branch lean-pr-testing-8000 has successfully built against this PR. (2025-04-25 16:02:35) View Log

@TwoFX TwoFX force-pushed the markus/ofnat_emod branch 2 times, most recently from 0b8a9bc to 1e3dca4 Compare April 22, 2025 08:43
@TwoFX TwoFX force-pushed the markus/ofnat_emod branch from 126fb63 to f596440 Compare April 25, 2025 13:26
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 25, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8000
6948088
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 25, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8000
5a006b4
@leanprover-community-bot leanprover-community-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Apr 25, 2025
@TwoFX TwoFX marked this pull request as ready for review April 25, 2025 16:16
@TwoFX TwoFX requested a review from kim-em as a code owner April 25, 2025 16:16
@TwoFX TwoFX enabled auto-merge April 25, 2025 16:16
@TwoFX TwoFX added this pull request to the merge queue Apr 25, 2025
Merged via the queue into master with commit 6cdabf5 Apr 25, 2025
28 checks passed
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request May 2, 2025
@kim-em @leanprover-community-mathlib4-bot
@TwoFX @Rob23oba @Kha @kmill @joelriou @Ruben-VandeVelde @jcommelin
chore: adaptations for nightly-2025-05-01 (#24524)
0ec9062 
* Trigger CI for leanprover/lean4#7971

* WIP

* WIP

* WIP

* Trigger CI for leanprover/lean4#7971

* Update lean-toolchain for testing leanprover/lean4#7975

* Fix

* Trigger CI for leanprover/lean4#7971

* remove adaptation notes

* Fix

* Fix

* chore: bump to nightly-2025-04-16

* revert some stuff

* Update lean-toolchain for testing leanprover/lean4#7983

* WIP

* Part one

* Part two

* lake update and fix

* Fix

* Trigger CI for leanprover/lean4#7983

* Shake

* chore: bump to nightly-2025-04-17

* lake update

* .

* chore: bump to nightly-2025-04-18

* Update lean-toolchain for testing leanprover/lean4#8021

* fix

* fix: !bench after Lake path changes (#24143)

* fix

* fix

* chore: bump to nightly-2025-04-19

* Merge master into nightly-testing

* temporarirly disable sythorder checking for Grind.IsCharP instance

* shake

* chore: bump to nightly-2025-04-20

* fix

* chore: bump to nightly-2025-04-21

* make fix more robust

* fix test

* chore: bump to nightly-2025-04-22

* .

* sorries

* sorries

* chore: bump to nightly-2025-04-23

* chore: bump to nightly-2025-04-24

* fix

* not there yet

* comment out

* comment out

* chore: bump to nightly-2025-04-25

* bump batteries

* more

* hacky fix?

* add comment

* fix lint-style

* Fix shake: Parser.parseHeader returns TSyntax instead of Syntax after the new module system

* Clean up

* Update lean-toolchain for testing leanprover/lean4#8000

* Lake update

* Fix

* Fix

* Fix

* Fix

* fix to Mathlib/Algebra/Homology/Embedding/Connect.lean

* Fix

* chore: bump to nightly-2025-04-26

* fix MinImports

* Update lean-toolchain for testing leanprover/lean4#8114

* lake update

* fix

* fixes

* fix

* fix deprecations

* remove accidental files

* chore: bump to nightly-2025-04-26

* chore: bump to nightly-2025-04-27

* fixes

* cleanup adaptation note

* shake --fix

* cleanup

* .

* cleanup

* cleanup

* cleanup

* comments

* cleanuo

* move batteries back to nightly-testing

* fix

* fix build hopefully?

* fix build hopefully?

* chore: bump to nightly-2025-04-28

* Update lean-toolchain for testing leanprover/lean4#8144

* lake update

* Fix

* fix grind instances

* shake

* Cleanup

* shake

* chore: bump to nightly-2025-04-29

* fix

* deprecation

* Update lean-toolchain for testing leanprover/lean4#8161

* shake

* fix GrindInstances

* basic test for grind +ring

* fixes for leanprover/lean4#8161

* fixes

* chore: adaptations for nightly-2025-04-29

* Merge master into nightly-testing

* chore: bump to nightly-2025-04-30

* lake update

* fix

* fix merge

* fix merge

* Drop a few unnecessary changes

* fix test

* chore: bump to nightly-2025-05-01

* fix

---------

Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
Co-authored-by: Markus Himmel <markus@lean-fro.org>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Rob23oba <robin.arnez@web.de>
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request May 5, 2025
@jcommelin @leanprover-community-mathlib4-bot
@Rob23oba @TwoFX @kim-em @Kha @kmill @joelriou @Ruben-VandeVelde
chore: adaptations for nightly-2025-05-03 (#24569)
4374ee0 
* chore: bump to nightly-2025-04-16

* revert some stuff


8A19
* Update lean-toolchain for testing leanprover/lean4#7983

* WIP

* Part one

* Part two

* lake update and fix

* Fix

* Trigger CI for leanprover/lean4#7983

* Shake

* chore: bump to nightly-2025-04-17

* lake update

* .

* chore: bump to nightly-2025-04-18

* Update lean-toolchain for testing leanprover/lean4#8021

* fix

* fix: !bench after Lake path changes (#24143)

* fix

* fix

* chore: bump to nightly-2025-04-19

* Merge master into nightly-testing

* temporarirly disable sythorder checking for Grind.IsCharP instance

* shake

* chore: bump to nightly-2025-04-20

* fix

* chore: bump to nightly-2025-04-21

* make fix more robust

* fix test

* chore: bump to nightly-2025-04-22

* .

* sorries

* sorries

* chore: bump to nightly-2025-04-23

* chore: bump to nightly-2025-04-24

* fix

* not there yet

* comment out

* comment out

* chore: bump to nightly-2025-04-25

* bump batteries

* more

* hacky fix?

* add comment

* fix lint-style

* Fix shake: Parser.parseHeader returns TSyntax instead of Syntax after the new module system

* Clean up

* Update lean-toolchain for testing leanprover/lean4#8000

* Lake update

* Fix

* Fix

* Fix

* Fix

* fix to Mathlib/Algebra/Homology/Embedding/Connect.lean

* Fix

* chore: bump to nightly-2025-04-26

* fix MinImports

* Update lean-toolchain for testing leanprover/lean4#8114

* lake update

* fix

* fixes

* fix

* fix deprecations

* remove accidental files

* chore: bump to nightly-2025-04-26

* chore: bump to nightly-2025-04-27

* fixes

* cleanup adaptation note

* shake --fix

* cleanup

* .

* cleanup

* cleanup

* cleanup

* comments

* cleanuo

* move batteries back to nightly-testing

* fix

* fix build hopefully?

* fix build hopefully?

* chore: bump to nightly-2025-04-28

* Update lean-toolchain for testing leanprover/lean4#8144

* lake update

* Fix

* fix grind instances

* shake

* Cleanup

* shake

* chore: bump to nightly-2025-04-29

* fix

* deprecation

* Update lean-toolchain for testing leanprover/lean4#8161

* shake

* fix GrindInstances

* basic test for grind +ring

* fixes for leanprover/lean4#8161

* fixes

* chore: adaptations for nightly-2025-04-29

* Merge master into nightly-testing

* chore: bump to nightly-2025-04-30

* lake update

* fix

* fix merge

* fix merge

* Drop a few unnecessary changes

* fix test

* chore: bump to nightly-2025-05-01

* fix

* Merge master into nightly-testing

* chore: bump to nightly-2025-05-02

* chore: bump to nightly-2025-05-03

* chore: adaptations for nightly-2025-05-03

---------

Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Rob23oba <robin.arnez@web.de>
Co-authored-by: Markus Himmel <markus@lean-fro.org>
Co-authored-by: Kim Morrison <kim@tqft.net>
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwoFX @leanprover-community-bot
0