8000 feat: improve error behavior of `end` command by jrr6 · Pull Request #8387 · leanprover/lean4 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: improve error behavior of end command #8387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 20, 2025
Merged

feat: improve error behavior of end command #8387

merged 11 commits into from
Jun 20, 2025

Conversation

jrr6
Copy link
Contributor
@jrr6 jrr6 commented May 16, 2025

This PR improves the error messages produced by end and prevents invalid end commands from closing scopes on failure.

@jrr6 jrr6 added the changelog-language Language features, tactics, and metaprograms label May 16, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 16, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 16, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8387
a61079b
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 16, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#8387
c0f7774
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label May 16, 2025
@leanprover-community-bot
Copy link
Collaborator
leanprover-community-bot commented May 16, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ✅ Mathlib branch lean-pr-testing-8387 has successfully built against this PR. (2025-05-16 21:53:49) View Log
  • ✅ Mathlib branch lean-pr-testing-8387 has successfully built against this PR. (2025-05-19 19:24:22) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase a7af9f7d5f6580071434d499e97ddbcccafb1a59 --onto 0a9c24649767dea857a388e5385b7ae94bfd0185. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-12 02:19:41)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase a7af9f7d5f6580071434d499e97ddbcccafb1a59 --onto 0077dd3d5569527f023865099890fa5aa9ffbe77. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-19 15:29:11)

Rob23oba
Rob23oba reviewed May 17, 2025
View reviewed changes
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 19, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#8387
efc929b
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 19, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#8387
0ec3908
@jrr6 jrr6 force-pushed the end-error-messages branch from 24f5531 to 8d390fe Compare June 12, 2025 01:16
@jrr6 jrr6 requested a review from nomeata June 19, 2025 03:19
nomeata
nomeata approved these changes Jun 19, 2025
View reviewed changes
jrr6 and others added 2 commits June 19, 2025 10:58
@jrr6 @nomeata
doc: improve wording
abd6fd9 
Co-authored-by: Joachim Breitner <mail@joachim-breitner.de>
@jrr6
test: remove redundant test
0f2a434
@jrr6 jrr6 added this pull request to the merge queue Jun 20, 2025
Merged via the queue into leanprover:master with commit f416143 Jun 20, 2025
15 checks passed
wkrozowski pushed a commit to wkrozowski/lean4 that referenced this pull request Jun 24, 2025
@jrr6 @Rob23oba
@nomeata @wkrozowski
feat: improve error behavior of end command (leanprover#8387)
7c985c9 
This PR improves the error messages produced by `end` and prevents
invalid `end` commands from closing scopes on failure.

---------

Co-authored-by: Rob23oba <152706811+Rob23oba@users.noreply.github.com>
Co-authored-by: Joachim Breitner <mail@joachim-breitner.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob23oba Rob23oba Rob23oba left review comments

@nomeata nomeata nomeata approved these changes

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrr6 @leanprover-community-bot @nomeata @Rob23oba
0