feat: polymorphic ranges #8784
Open
feat: polymorphic ranges #8784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17a7c4a to
23b9390
Compare
b3e6ea4 to
6b335e6
Compare
23b9390 to
0c96c36
Compare
|
Mathlib CI status (docs):
|
6b335e6 to
db499e9
Compare
2ce1833 to
5fe9499
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 23, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 23, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 23, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 23, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 23, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 23, 2025
… interpreted as .. and .
range notation with two dots conflicts with ellipses in object notation ("{ abc.. }").
15482bc to
7ee86a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces ranges that are polymorphic, in contrast to the existing
Std.Rangewhich only supports natural numbers.Breakdown of core changes:
Lean.Parser.Basic: Modified the number parser (Lean.Parser.Basic) so that it will only consider a single dot to be part of a decimal number.1..will no longer be parsed as1.followed by., but as1followed by...ellipsisProjIssueensures that#check Nat.add ...succproduces a syntax error. After introducing the new range notation (see below), it returns a different (less nice) error message. I updated the test to reflect the new error message. (The error message will become nicer as soon as a delaborator for the ranges is implemented. This is out of scope for this PR.)Breakdown of standard library changes:
Modified modules:
Init.Data.Range.Polymorphic(added),Init.Data.Iterators,Std.Data.IteratorsStd.PRangethat is parameterized over the type in which the range operates and the shapes of the lower and upper bound.1...*,1...=3,1...<3,1<...=2,*...=3.Iter(M).size.Iter(M).stepSize ncombinator, which iterates over an iterator with the given step sizen. It will dropn - 1values between every value it emits.LawfulPureIteratorwith a new and better typeclassLawfulDeterministicIterator.IterM.toList_eq_match, which unnecessarily matched over aSubtype, hindering rewrites due to type dependencies.Reasons for the concrete choice of notation:
lean4-cliuses...-based notation for theCmdnotation and it clashes with...arange notation.2461fails when using two-dot-based notation because of the existing{ a.. }notation.