fix: update Parser.Term.letIdDeclNoBinders to use new letIdDecl format
#8929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat This PR is a followup to leanprover#8914, fixing an oversight where `letIdDeclBinders` is was not updated with the new format. This just means that we will need another stage0 update and cleanup. This PR does stage0 cleanup that is possible at this moment.
|
Mathlib CI status (docs):
|
kmill
added a commit
to kmill/lean4
that referenced
this pull request
Jun 22, 2025
This PR finishes post-stage0-cleanup after leanprover#8914 and leanprover#8929. Also: - adds configuration options for `haveI` and `letI` terms. - adds `letConfig` parser alias
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 22, 2025
<
8000
a href="/leanprover/lean4/commit/bb0132e4b32e116627fe8b94b4d0025dd4b69801" class="Link--secondary">bb0132e
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
…ormat (leanprover#8929) This PR is a followup to leanprover#8914, fixing an oversight where `letIdDeclBinders` is was not updated with the new format. This relies on some bootstrapping code to stay in place, but we do bootstrap cleanup that is currently possible.
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
This PR finishes post-stage0-cleanup after leanprover#8914 and leanprover#8929. Also: - adds configuration options for `haveI` and `letI` terms. - adds `letConfig` parser alias
nomeata
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be
2F1D
applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #8914, fixing an oversight where
letIdDeclBindersis was not updated with the new format. This relies on some bootstrapping code to stay in place, but we do bootstrap cleanup that is currently possible.