8000 fix: better case-split for match-conditions in `grind` by leodemoura · Pull Request #8958 · leanprover/lean4 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: better case-split for match-conditions in grind #8958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

fix: better case-split for match-conditions in grind #8958

merged 1 commit into from
Jun 24, 2025

Conversation

leodemoura
Copy link
Member

This PR improves the case splitting strategy used in grind, and ensures grind also considers simple match-conditions for case-splitting. Example:

example (x y : Nat)
    : 0 < match x, y with
          | 0, 0   => 1
          | _, _ => x + y := by -- x or y must be greater than 0
  grind

@leodemoura
fix: better case-split for match-conditions in grind
b128c3e 
This PR improves the case splitting strategy used in `grind`, and
ensures `grind` also considers simple `match`-conditions for
case-splitting.  Example:

```lean
example (x y : Nat)
    : 0 < match x, y with
          | 0, 0   => 1
          | _, _ => x + y := by -- x or y must be greater than 0
  grind
```
@leodemoura leodemoura added the changelog-language Language features, tactics, and metaprograms label Jun 24, 2025
@leodemoura leodemoura enabled auto-merge June 24, 2025 02:42
@leodemoura leodemoura added this pull request to the merge queue Jun 24, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 24, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 81740da50af938a35620ae6d319ee1c63e29f164 --onto db499e96aac8ad654c8ed5ab40c4e6885d38c9a1. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-24 03:11:35)

auto-merge was automatically disabled June 24, 2025 03:15

Pull Request is not mergeable

Merged via the queue into master with commit 07662aa Jun 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leodemoura @leanprover-community-bot
0