Logger #80
Merged
Logger #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkpr
approved these changes
May 16, 2025
| if interval_idx == interval_idx_prev: | ||
| return None | ||
|
|
||
| def clean_until(t: int) -> None: |
There was a problem hiding this comment.
Consider moving this out of/ parallel to update
| self._timestamps: dict = defaultdict(list) | ||
| self._statistics: dict = defaultdict(list) | ||
|
|
||
| def update( |
There was a problem hiding this comment.
Functionality looks good! But update appears like we should make it clearer by refactoring its content into smaller subfunctions
| @@ -74,7 +75,7 @@ class SacBaseConfig(BaseConfig): | |||
| sac: SacAlgorithmConfig = field(default_factory=SacAlgorithmConfig) | |||
| train: TrainConfig = field(default_factory=TrainConfig) | |||
| val: ValConfig = field(default_factory=ValConfig) | |||
| log: LogConfig = field(default_factory=LogConfig) | |||
| log: LoggerConfig = field(default_factory=LoggerConfig) | |||
There was a problem hiding this comment.
Rename to logger for consistent variable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the logging in leap-c, to make it more consistent and easier to maintain in the future:
Logger, to remove logging functionality from the trainer:10.000steps and is reported every1.000steps:with_smoothingflag, when reporting a stat. This is used for example for the validation results.