8000 Controller by JasperHoffmann · Pull Request #86 · leap-c/leap-c · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Controller #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 27, 2025
Merged

Controller #86

merged 21 commits into from
May 27, 2025

Conversation

JasperHoffmann
Copy link
Collaborator
@JasperHoffmann JasperHoffmann commented May 26, 2025

This PR adds an abstract controller interface:

  1. The controller interface provides an interface that is used by RL algorithms to interface with potentially differentiable controllers.
  2. The ctx object can save calculations needed to get the jacobian_action_param or can store information needed for the next forward pass such as the solver state.
  3. We further improved the differentiable function specifications by adding an abstract DiffFunction class.

@JasperHoffmann JasperHoffmann requested a review from dirkpr May 26, 2025 13:02
Copy link
Contributor
@dirkpr dirkpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controller.py looks good. See previous PR for renaming comments

@JasperHoffmann JasperHoffmann requested a review from dirkpr May 26, 2025 14:47
7C5F
@JasperHoffmann JasperHoffmann merged commit a1a0780 into leap-c:main May 27, 2025
1 check passed
@JasperHoffmann JasperHoffmann deleted the controller branch May 27, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0