Make ServiceAccount kubeconfig context name differ from cluster context name #7433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r name Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
|
Not really a bug, but should be safe to put in a patch release. |
Nokel81
approved these changes
Mar 31, 2023
|
Still think that it shouldn't go into a patch release. But yes minor. |
jweak
pushed a commit
that referenced
this pull request
Apr 3, 2023
…xt name (#7433) Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ServiceAccount kubeconfig is generated with a context that has the same name as the associated cluster, which is typically the cluster's context name too. This makes it difficult to distinguish the "clusters" in the cluster list. This PR appends the username (ServiceAccount name) to the cluster name to make it more unique.