Wait app to be ready before creating a BrowserWindow for system proxy resolver #7443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resolver Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Iku-turso
reviewed
Mar 31, 2023
packages/core/src/main/utils/resolve-system-proxy/resolve-system-proxy-window.injectable.ts
Show resolved
Hide resolved
Iku-turso
reviewed
Mar 31, 2023
| @@ -4,13 +4,21 @@ | |||
| */ | |||
| import { getInjectable } from "@ogre-tools/injectable"; | |||
| import { BrowserWindow } from "electron"; | |||
| import electronAppInjectable from "../../electron-app/electron-app.injectable"; | |||
|
|
|||
| const resolveSystemProxyWindowInjectable = getInjectable({ | |||
There was a problem hiding this comment.
Name indicates function, but it's actually a window. Proposed name: systemProxyWindowInjectable.
Iku-turso
reviewed
Mar 31, 2023
packages/core/src/main/utils/resolve-system-proxy/resolve-system-proxy-window.injectable.ts
Show resolved
Hide resolved
|
This is a kludgy hot-fix PR, and requires concrete plan to be done properly with eg. unit tests. |
Iku-turso
approved these changes
Mar 31, 2023
Closed
Iku-turso
pushed a commit
that referenced
this pull request
Mar 31, 2023
… resolver (#7443) Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Merged
Iku-turso
added a commit
that referenced
this pull request
Mar 31, 2023
* wait app to be ready before creating a BrowserWindow for system proxy resolver (#7443) Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> * Release 6.4.12 Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> --------- Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> Co-authored-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
jweak
pushed a commit
that referenced
this pull request
Apr 3, 2023
… resolver (#7443) Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #7436 .