8000 Fix: stale resource in details panel after update from apis/store by ixrock · Pull Request #7187 · lensapp/lens · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: stale resource in details panel after update from apis/store #7187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Fix: stale resource in details panel after update from apis/store #7187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
998a9e8
PoC: Stale resource in details panel after update from apis/store, fi…
ixrock Feb 17, 2023
5a88444
clean up: get rid of old implementation of `currentKubeObjectInDetail…
ixrock Feb 20, 2023
980a9f5
Merge remote-tracking branch 'origin/master' into fix/resource_detail…
ixrock Feb 21, 2023
86f6f39
Merge remote-tracking branch 'origin/master' into fix/resource_detail…
ixrock Feb 22, 2023
c739d7e
switch to `asyncComputed`
ixrock Feb 22, 2023
7b862b9
update snapshots with a new command `npm run test:update-snapshots` f…
ixrock Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
186 changes: 37 additions & 149 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"dev": "cross-env NODE_ENV=development webpack --config webpack/library-bundle.ts --watch",
"test:unit": "jest --testPathIgnorePatterns integration",
"test:watch": "func() { jest ${1} --watch --testPathIgnorePatterns integration; }; func",
"test:update-snapshots": "jest --updateSnapshot src",
"lint": "PROD=true eslint --ext js,ts,tsx --max-warnings=0 .",
"lint:fix": "npm run lint --fix"
},
Expand Down Expand Up @@ -204,10 +205,10 @@
"@swc/cli": "^0.1.61",
"@swc/core": "^1.3.35",
"@swc/jest": "^0.2.24",
"@testing-library/dom": "^7.31.2",
"@testing-library/dom": "^9.0.0",
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^12.1.5",
"@testing-library/user-event": "^13.5.0",
"@testing-library/user-event": "^14.4.3",
"@types/byline": "^4.2.33",
"@types/chart.js": "^2.9.36",
"@types/circular-dependency-plugin": "5.0.5",
Expand Down
38 changes: 0 additions & 38 deletions ...ures/cluster/__snapshots__/legacy-extension-adding-cluster-frame-components.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,44 +2,6 @@

exports[`legacy extension adding cluster frame components given custom components for cluster view available renders 1`] = `
<div>
<div
class="Animate slide-right Drawer KubeObjectDetails flex column right enter leave"
style="--size: 725px; --enter-duration: 100ms; --leave-duration: 100ms;"
>
<div
class="drawer-wrapper flex column"
>
<div
class="drawer-title flex align-center"
>
<div
class="drawer-title-text flex gaps align-center"
>

</div>
<i
class="Icon material interactive focusable"
tabindex="0"
>
<span
class="icon"
data-icon-name="close"
>
close
</span>
</i>
<div>
Close
</div>
</div>
<div
class="drawer-content flex column box grow"
/>
</div>
<div
class="ResizingAnchor horizontal leading"
/>
</div>
<div
class="Notifications flex column align-flex-end"
/>
Expand Down
Loading
0