8000 Fix problems when using 'npm link' by Nokel81 · Pull Request #7380 · lensapp/lens · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix problems when using 'npm link' #7380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2023
Merged

Fix problems when using 'npm link' #7380

merged 3 commits into from
Mar 20, 2023

Conversation

Nokel81
Copy link
Collaborator
@Nokel81 Nokel81 commented Mar 20, 2023

  • Add missing peerDependencies and devDependencies

  • Move 'overrides' to root package to fix audit issues

@Nokel81
Fix problems when using 'npm link'
5276680 
- Add missing peerDependencies and devDependencies

- Move 'overrides' to root package to fix audit issues

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 added the dependencies Pull requests that update a dependency file label Mar 20, 2023
@Nokel81 Nokel81 added this to the 6.5.0 milestone Mar 20, 2023
8000 @Nokel81 Nokel81 requested a review from a team as a code owner March 20, 2023 13:24
@Nokel81 Nokel81 requested review from ixrock and gabriel-mirantis and removed request for a team March 20, 2023 13:24
jansav
jansav previously approved these changes Mar 20, 2023
View reviewed changes
@Nokel81
Fix type issue and remove deprecated @types/* deps
f4f2b83 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Fixing type errors harder
390740f 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 merged commit df49ff9 into master Mar 20, 2023
@Nokel81 Nokel81 deleted the fix-missing-peer-deps branch March 20, 2023 19:43
gabriel-mirantis pushed a commit that referenced this pull request Mar 21, 2023
@Nokel81 @gabriel-mirantis
Fix problems when using 'npm link' (#7380)
8560333 
* Fix problems when using 'npm link'

- Add missing peerDependencies and devDependencies

- Move 'overrides' to root package to fix audit issues

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix type issue and remove deprecated @types/* deps

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fixing type errors harder

Signed-off-by: Sebastian Malton <sebastian@malton.name>

---------

Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Gabriel <gaccettola@mirantis.com>
@Nokel81 Nokel81 mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-mirantis gabriel-mirantis gabriel-mirantis approved these changes

@jansav jansav jansav left review comments

@ixrock ixrock Awaiting requested review from ixrock ixrock is a code owner automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Nokel81 @jansav @gabriel-mirantis
0