8000 Remove possible warnings with redefinitions by attila0x2A · Pull Request #71 · lewissbaker/cppcoro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove possible warnings with redefinitions #71

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2018
Merged

Remove possible warnings with redefinitions #71

merged 1 commit into from
Mar 27, 2018

Conversation

attila0x2A
Copy link
Contributor

If the library is used as part of a bigger project some definitions can
be provided via external build files.

@attila0x2A
Remove possible warnings with redefinitions
936e6ee 
If the library is used as part of a bigger project some definitions can
be provided via external build files.
@lewissbaker
Copy link
Owner

So the issue you're trying to solve here is that you're already defining WIN32_LEAN_AND_MEAN on the command-line in your build system which is compiling cppcoro sources directly rather than using the output of the cake build system?

There are a couple of new files in the sockets2 branch that may require compilation without WIN32_LEAN_AND_MEAN defined. I'll try out this change with those branches but otherwise it seems like a reasonable change to me.

@attila0x2A
Copy link
Contributor Author

So the issue you're trying to solve here is that you're already defining WIN32_LEAN_AND_MEAN on the command-line in your build system which is compiling cppcoro sources directly rather than using the output of the cake build system?

Yes, exactly.

@lewissbaker lewissbaker merged commit a19b13b into lewissbaker:master Mar 27, 2018
@attila0x2A attila0x2A deleted the redef_warnings branch March 28, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attila0x2A @lewissbaker
0