8000 Fix esp8266_spi compilation by jonware · Pull Request #135 · lexus2k/lcdgfx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix esp8266_spi compilation #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2025
Merged

Fix esp8266_spi compilation #135

merged 1 commit into from
Jun 14, 2025

Conversation

jonware
Copy link
Contributor
@jonware jonware commented Jun 14, 2025

Compilation for esp8266 is failing:

CXX build/lcdgfx/src/lcd_hal/esp/esp8266_spi.o
/home/jon/Development/ssd1306_test/components/lcdgfx/src/lcd_hal/esp/esp8266_spi.cpp: In member function 'void EspSpi::forceSpiTransfer()':
/home/jon/Development/ssd1306_test/components/lcdgfx/src/lcd_hal/esp/esp8266_spi.cpp:177:26: error: cannot convert 'spi_trans_t' to 'spi_trans_t*'
         spi_trans(m_spi, t);
                          ^
In file included from /home/jon/Development/ssd1306_test/components/lcdgfx/src/lcd_hal/esp/../esp/esp8266_spi.h:34,
                 from /home/jon/Development/ssd1306_test/components/lcdgfx/src/lcd_hal/esp/../io.h:74,
                 from /home/jon/Development/ssd1306_test/components/lcdgfx/src/lcd_hal/esp/esp8266_spi.cpp:25:
/home/jon/esp/ESP8266_RTOS_SDK/components/esp8266/include/driver/spi.h:413:51: note:   initializing argument 2 of 'esp_err_t spi_trans(spi_host_t, spi_trans_t*)'
 esp_err_t spi_trans(spi_host_t host, spi_trans_t *trans);
                                      ~~~~~~~~~~~~~^~~~~
make[1]: *** [/home/jon/esp/ESP8266_RTOS_SDK/make/component_wrapper.mk:292: src/lcd_hal/esp/esp8266_spi.o] Error 1
make: *** [/home/jon/esp/ESP8266_RTOS_SDK//make/project.mk:571: component-lcdgfx-build] Error 2

This corrects the call to spi_trans() by passing in a pointer to the spi_trans_t structure.

@jonware
Fix esp8266_spi compilation
8264a65 
Corrected call to spi_trans by passing in pointer to spi_trans_t
structure.
@CLAassistant
Copy link
CLAassistant commented Jun 14, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lexus2k lexus2k merged commit 529c7ef into lexus2k:master Jun 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonware @CLAassistant @lexus2k
0