8000 Re-enable pipenv tests with Python 3.x by nozaq · Pull Request #815 · licensee/licensed · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Re-enable pipenv tests with Python 3.x #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2025
Merged

Re-enable pipenv tests with Python 3.x #815

merged 1 commit into from
Mar 2, 2025

Conversation

nozaq
Copy link
Collaborator
@nozaq nozaq commented Feb 28, 2025 •
edited
Loading

This PR re-enables pipenv tests with Python 3.x in the test matrix. They were previously failing because pyzmq, which was locked to an older version, caused an installation error.

This PR includes the following changes:

  • Update indirect dependencies in Pipfile.lock, upgrading pyzmq so it’s compatible with Python 3.x.
  • Explicitly add lazy-object-proxy to the Pipfile to ensure it isn’t accidentally removed in future updates. This dependency is required for the test cases to pass.
  • Add a missing assertion.

MikeMcQuaid
MikeMcQuaid approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor
@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nozaq!

@MikeMcQuaid MikeMcQuaid merged commit c6ce63b into licensee:main Mar 2, 2025
46 checks passed
@nozaq nozaq deleted the fix-ci-pip branch March 2, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nozaq @MikeMcQuaid
0