libmtp configure putting UDEV files in the wrong location #271 #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a better solution for './configure' and the "/usr/lib/udev" problem
when running 'make distcheck' and programs like 'rpmbuild -ba' that still
required values like {prefix}. The solution was to set:
UDEV=\${prefix}/../lib/udev (for prefix=/usr/local) or
UDEV=\${prefix}/lib/udev (for prefix=/usr).
Also copied UDEV to TARGET_UDEV so that we can simplify the if/then/else,
and this simplified Makefile.am so we don't need to use the UDEV_SNIPPET.
TARGET_UDEV is then overwritten with crossbuilddir if we're crossbuilding
otherwise it remains as whatever directory UDEV originally set it to.
Also added AC_MSG_NOTICE() so we can see results of using './configure'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a better solution for './configure' and the "/usr/lib/udev" problem when running 'make distcheck' and programs like 'rpmbuild -ba' that still required values like {prefix}. The solution was to set: UDEV=${prefix}/../lib/udev (for prefix=/usr/local) or UDEV=${prefix}/lib/udev (for prefix=/usr).
Also copied UDEV to TARGET_UDEV so that we can simplify the if/then/else, and this simplified Makefile.am so we don't need to use the UDEV_SNIPPET. TARGET_UDEV is then overwritten with crossbuilddir if we're crossbuilding otherwise it remains as whatever directory UDEV originally set it to.
Also added AC_MSG_NOTICE() so we can see results of using './configure'.
Hopefully this resolves issue #271.