Where to report bugs - addition of SOFA's E-mail address to README.rst #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2716212 to
7b92c2d
Compare
eteq
added a commit
that referenced
this pull request
Feb 3, 2016
adds SOFA's E-mail address to README.rst Rebased on master before merging
|
I merged this manually in a71e72a, so closing this. Not a big deal, but, @jwoillez, in the future if a situation like this this comes up it would have been better to just have a PR with only the final commit here. It's independent of the other changes, and it keeps the git history cleaner to keep those separate. That's what I ended up merging anyway, but had to do it manually. |
|
Oh well. I thought it would make your life easier with the second PR rebased on what master would become. |
|
@jwoillez - definitely a reasonable thought! It's mostly just because of how github shows diffs that this is slightly inconvenient. Really not a big deal but thought I would mention it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #29, and to be merged after #30.