Fixed linker errors in SH #809
Conversation
|
Thanks for your submission -- but this is not really a patch that applies to the libffi repo. This patch should probably consist of changes to existing files, but instead you are providing new files that the build system wouldn't know how to use. |
Oh darn. I put up the wrong files in my commit. Let me redo my pr and I’ll tag you when it’s ready. I apologize for getting you to review a half baked pr. |
d8cfa47 to
adbcf2b
Compare
…in SH source. This work is to allow FFI usage on the Sega Dreamcast, specifically NSInvocation in Libs-Base (Objective-c Foundation)
|
@atgreen I have updated the PR with the proper commit. Sorry about the mix up. |
|
Thanks for the update. The problem with this patch is that the leading underscore is not required for sh4-linux targets. See the test results with your patch here: https://rl.gl/doc-text?id=RLGL-O3HSVIWV Check your configure output. Does it define SYMBOL_UNDERSCORE ? If so, we can use that in the asm code. |
These were the same errors I was seeing on sh4-kos. I'll check my output and comment back. |
|
By the way, sorry to intrude, but I'm a bit curious as to why SH-4 isn't actually listed as a supported architecture on the main README for the repository? We almost didn't bother trying to get this up and running on the Sega Dreamcast, because we didn't know if there was an SH4 implementation until we dug into the source... Seems to be working fine for us? We definitely have a community of interested developers along with the sh-linux guys! :) |
|
More likely just a difference between linux and embedded elf targets.
…On Fri, Nov 24, 2023 at 8:28 PM Falco Girgis ***@***.***> wrote:
Also, guys, note that we're using sh-elf-gcc-13.2.0--the latest n
greatest--for Sega Dreamcast development, but it looks like GCC8 in CI for
sh-linux-gcc? Perhaps the default underscore behavior could have changed
between the two?
—
Reply to this email directly, view it on GitHub
<#809 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAV7CPYYYZNGUOKLZIP6YLYGFCUTAVCNFSM6AAAAAA7W2VYVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGE3TQOJUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
That was an oversight, which I've just corrected with commit 1b6b176 |
Updated ffi_call_SYSV, ffi_closure_helper_SYSV, and ffi_closure_SYSV in SH source. This work is to allow FFI usage on the Sega Dreamcast, specifically NSInvocation in Libs-Base (Objective-c Foundation).
These changes were tested on the KOS toolchain.