Added missing header gd_io_stream.h (fix issue #397) #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated src/Makefile.am and arc/CMakeLists.txt to include the missing file. Also moved header includes fromall on one line to separate lines as it was getting a ittle long.
Added C++ source files to src/Makefile.am Added C++ compiler to configure.ac
|
The Automake build was also missing the C++ source files leading to missing symbol errors so I have now added these. It seems my Linux distro (Fedora 25) packages this library using Automake. |
|
this won't fly as it changes the ABI/C++ linkage unconditionally. let's keep the discussion in the referenced bug. |
<
5ACA
/div>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offered for consideration. Should fix Issue #397
Updated
src/Makefile.amandsrc/CMakeLists.txtto include the missing file.Also moved header includes from all on one line to separate lines as it was getting a little long.