Removed duplicate code in TmxMapLoader #7136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HydrolienF
suggested changes
May 2, 2023
There was a problem hiding this comment.
It seems to be a good pr.
For performance improvement fileHandle can be set once only by doing somethig like that :
FileHandle fileHandle;
if (source != null) {
fileHandle = getRelativeFileHandle(tmxFile, source);
tileset = xml.parse(fileHandle);
}else{
fileHandle = tmxFile;
}|
Looks good to me. |
HydrolienF
approved these changes
May 3, 2023
BoBIsHere86
added a commit
to BoBIsHere86/libgdx
that referenced
this pull request
Apr 29, 2025
…Loader to reflect PR libgdx#7136's code duplication fix. Did the same for the TmjMapLoader as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted the common variable to simplify some similar code