8000 Use box-drawing characters in comments. by jdumas · Pull Request #2466 · libigl/libigl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use box-drawing characters in comments. #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

Use box-drawing characters in comments. #2466

merged 2 commits into from
Apr 25, 2025

Conversation

jdumas
Copy link
Collaborator
@jdumas jdumas commented Apr 25, 2025

To avoid compiler warnings of the style:

include/igl/AABB.cpp:549:3: warning: multi-line comment [-Wcomment]
549 |   //            /  \

I've replaced comments using forward/backward slashes with unicode box-drawing characters. This avoids ending a comment with a trailing backslash, which can trigger some annoying compiler warnings.

Checklist

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • This is a minor change.

@alecjacobson
Copy link
Contributor

Thanks. Should probably compile, but the hard-coded ubuntu-20.4 is retired. Do you remember why the version is hard-coded rather than ubuntu-latest?

@jdumas
Copy link
Collaborator Author
jdumas commented Apr 25, 2025

Do you remember why the version is hard-coded rather than ubuntu-latest

Hmm no particular reason. I think I may have wanted to test compatibility on the "oldest" available ubuntu image.

@jdumas jdumas enabled auto-merge (squash) April 25, 2025 18:30
@jdumas jdumas disabled auto-merge April 25, 2025 20:20
@jdumas jdumas merged commit 89267b4 into main Apr 25, 2025
17 checks passed
@jdumas jdumas deleted the jedumas/box branch April 25, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0