Avoid creating huge list of numbers for cheat-related settings #18049
+30
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great news. This is a common complaint among people trying to use the cheat search, so we very much appreciate the contribution. @sonninnos and @LibretroAdmin are good reviewers for this sort of thing. |
This was referenced Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the "Value" and "Rumble Value" setting for cheats to bring up a keyboard for typing, rather than
creating a list of numbers to choose from. Previously, setting the cheat to be 32-bit would cause trying to select any of those settings to allocate a huge amount of memory, due to the option trying to create a list of all integers up to 2^32. Eventually this would crash RetroArch (and the entire system too, in my case).
I used Network->Netplay TCP Port as a reference for this implementation.
2025-06-25.01-00-14.mp4
Related Issues
This should fix #11431.
Related Pull Requests
None
Reviewers
None