10000 Add support for orphan_file and metadata_csum features · Issue #13 · libyal/libfsext · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for orphan_file and metadata_csum features #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rgayon opened this issue Feb 28, 2024 · 4 comments
Closed

Add support for orphan_file and metadata_csum features #13

rgayon opened this issue Feb 28, 2024 · 4 comments
Assignees
@joachimmetz
Labels
enhancement

Comments

@rgayon
Copy link
rgayon commented Feb 28, 2024

This feature was enabled by default in e2fsprogs mkfs version 1.47.0

Some OS have decided to disable it later in their packagings, for example Ubuntu enabled orphan_file in e2fsprogs (1.47.0-1) on 23.04, and then disabled it "temporarily" in 1.47.0-1ubuntu2, and then "definitely" in 1.47.0-2 for 23.10
@rgayon
Copy link
Author
rgayon commented Feb 28, 2024

On a FS with this feature enabled, such as displayed here:

$ sudo tune2fs -l /dev/sda1 | grep features
Filesystem features:      has_journal ext_attr resize_inode dir_index orphan_file filetype extent 64bit flex_bg sparse_super large_file huge_file dir_nlink extra_isize metadata_csum

using this library to parse the filesystem's partitions will lead to error:
libfsext_superblock_read_data: unsupported compatible features flags: 0x0000103c.

@joachimmetz joachimmetz self-assigned this Feb 28, 2024
@joachimmetz
Copy link
Member
joachimmetz commented Feb 28, 2024 •
edited
Loading

Looks like there are a couple more related flags e.g. EXT4_FEATURE_RO_COMPAT_ORPHAN_PRESENT https://elixir.bootlin.com/linux/latest/source/fs/ext4/ext4.h

Also metadata_csum is currently not supported

I'll have a look when time permits

@joachimmetz
Copy link
Member
joachimmetz commented Mar 1, 2024 •
edited
Loading

Was able to create file system with the flag using mke2fs -E orphan_file_size=# per documentation found so far looks like this flag controls the use of the orphan file (s_orphan_file_inum) instead of the orphan list.

@joachimmetz joachimmetz changed the title add support for EXT4_FEATURE_COMPAT_ORPHAN_FILE Add support for orphan_file and metadata_csum features Mar 1, 2024
joachimmetz added a commit that referenced this issue Mar 1, 2024
@joachimmetz
Worked on format support #13
415206a
joachimmetz added a commit that referenced this issue Mar 2, 2024
@joachimmetz
Worked on format support #13
921a58c
joachimmetz added a commit that referenced this issue Mar 2, 2024
@joachimmetz
Worked on format support #13
26d0843
@joachimmetz
Copy link
Member

Basic support was added, closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joachimmetz joachimmetz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joachimmetz @rgayon
0