fix: Missing check indicator when moving Spaces into root level #14868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we make sure that the "summary" message is always visible? Or should this summary message be smaller and somewhere else? |
joaoviana
reviewed
May 19, 2025
| @@ -109,7 +104,7 @@ const TreeItem: React.FC<Props> = ({ | |||
| {stringLabel} | |||
| </Highlight> | |||
|
|
|||
| {!isRoot && selected && ( | |||
| {selected && ( | |||
There was a problem hiding this comment.
Should we highlight the row as well when 'All spaces' is selected?
There was a problem hiding this comment.
Oh, you shouldn't be able to move a chart into the root space (only spaces) 👀
Working on a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #14857
Description:
Display check ✓ icon when selecting root + some other style improvements:
Reviewer actions