8000 fix: SQL Runner Update Chart not working by lakshz · Pull Request #14813 · lightdash/lightdash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: SQL Runner Update Chart not working #14813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

fix: SQL Runner Update Chart not working #14813

merged 2 commits into from
May 30, 2025
+32 −1

Conversation

lakshz
Copy link
Contributor
@lakshz lakshz commented May 14, 2025 •
edited
Loading

Closes: #14596

Description:

The savedSqlChart state in the sqlRunner redux slice wasn’t being updated after saving changes. I used the existing setSavedChartData reducer method to update the state.

Screen.Recording.2025-05-14.at.20.26.38.mov

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@magnew magnew self-requested a review May 14, 2025 15:10
@almeidabbm almeidabbm mentioned this pull request May 22, 2025
Closed
3 tasks
@owlas owlas requested a deployment to duplicate_sql-runner-update-chart-modal - jaffle_db_pg_13 PR #14931 May 22, 2025 09:19 — with Render Abandoned
@owlas owlas temporarily deployed to duplicate_sql-runner-update-chart-modal - headless-browser PR #14931 May 22, 2025 09:19 — with Render Destroyed
@owlas owlas temporarily deployed to duplicate_sql-runner-update-chart-modal - lightdash PR #14931 May 29, 2025 17:11 — with Render Destroyed
magnew
magnew approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor
@magnew magnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Code looks good -- works well!

Apologies for the delayed review 🙇 It's been busy.

@magnew magnew merged commit 7e56463 into lightdash:main May 30, 2025
6 checks passed
lightdash-bot pushed a commit that referenced this pull request May 30, 2025
@semantic-release-bot
chore(release): 0.1668.1
6910a63 
## [0.1668.1](0.1668.0...0.1668.1) (2025-05-30)

### Bug Fixes

* SQL runner update chart modal ([#14813](#14813)) ([7e56463](7e56463))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1668.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnew magnew magnew approved these changes

Assignees

@lakshz lakshz

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating a SQL Runner chart name, doesn't get refreshed
4 participants
@lakshz @lightdash-bot @magnew @owlas
0