feat: get ai agent (api+ui) #14917
Merged
feat: get ai agent (api+ui) #14917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2025
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. |
86b58ed to
55c7dd2
Compare
616ba0d to
008ff71
Compare
e5c5f68 to
9d82c3a
Compare
3 tasks
notgiorgi
approved these changes
May 21, 2025
9d82c3a to
150c32c
Compare
008ff71 to
cbba288
Compare
150c32c to
55c1a7c
Compare
this is updated in the code 🫡 |
cbba288 to
6654b45
Compare
55c1a7c to
6350316
Compare
6350316 to
cf76e5d
Compare
6654b45 to
1126f97
Compare
111558f
into
05-21-feat_create_ai_agent_api_ui_
2 of 3 checks passed
IrakliJani
pushed a commit
that referenced
this pull request
May 22, 2025
Comment on lines
106
to
+110
| form.setValues({ | ||
| name: agent.results.name, | ||
| projectUuid: agent.results.projectUuid, | ||
| integrations: agent.results.integrations, | ||
| tags: agent.results.tags, 8000 | ||
| name: agent.name, | ||
| projectUuid: agent.projectUuid, | ||
| integrations: agent.integrations, | ||
| tags: agent.tags, |
There was a problem hiding this comment.
The code accesses agent properties directly without verifying the object exists first. This could cause runtime errors if the agent data hasn't loaded yet. Consider adding a null check before setting form values:
if (agent) {
form.setValues({
name: agent.name,
projectUuid: agent.projectUuid,
integrations: agent.integrations,
tags: agent.tags,
});
}This would prevent potential "cannot read property of undefined" errors during the component's rendering cycle.
Suggested change
| form.setValues({ | |
| name: agent.results.name, | |
| projectUuid: agent.results.projectUuid, | |
| integrations: agent.results.integrations, | |
| tags: agent.results.tags, | |
| name: agent.name, | |
| projectUuid: agent.projectUuid, | |
| integrations: agent.integrations, | |
| tags: agent.tags, | |
| if (agent) { | |
| form.setValues({ | |
| name: agent.name, | |
| projectUuid: agent.projectUuid, | |
| integrations: agent.integrations, | |
| tags: agent.tags, | |
| }); | |
| } | |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
IrakliJani
added a commit
that referenced
this pull request
May 22, 2025
* feat: list ai agents * fix: left join * feat: create/update ai agent (api+ui) (#14914) * feat: create ai agent (api+ui) * feat: get ai agent (api+ui) (#14917) * feat: get ai agent (api+ui) * feat: allow deleting agents (#14919) * feat(backend): implement AI agent threads API endpoints (#14918) * feat(backend): agent threads * feat(frontend): agent threads (#14921) --------- Co-authored-by: Irakli Janiashvili <irakli.janiashvili@gmail.com> --------- Co-authored-by: João Viana <joao@lightdash.com> Co-authored-by: Giorgi Bagdavadze <12987425+notgiorgi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #ISSUE_NUMBER
Description:
Implements the "Get Agent" API endpoint and fixes the agent details view in the frontend.
The changes include:
getAgentcontroller method that was previously throwing aNotImplementedErrorAiAgentModelto properly handle null integrations withCOALESCEandFILTERReviewer actions