fix: required dashboard filters for SQL charts #15234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Base automatically changed from
refactor_split_Filter_component_into_Filter_and_AddFilterButton
to
main
June 11, 2025 09:01
magnew
approved these changes
Jun 11, 2025
6dc0d9d to
3e139cd
Compare
|
Your preview environment pr-15234 has been deployed. Preview environment endpoints are available at: |
|
Preview environment logs can be accessed at: https://console.cloud.google.com/logs/query;query=resource.labels.namespace_name%3D%22pr-15234%22;duration=PT30M?project=lightdash-previews |
lightdash-bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
# [0.1705.0](0.1704.0...0.1705.0) (2025-06-11) ### Features * add fallbackType to DashboardFieldTarget for SQL column filters ([#15234](#15234)) ([ad15d87](ad15d87))
|
🎉 This PR is included in version 0.1705.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #15161
Description:
Before:
After:
AI Description:
Added support for fallback type in dashboard filter targets to improve filter handling when fields or columns are not immediately available. This allows filters to function properly even when the underlying data structure is still loading or when using SQL columns.
Key changes:
fallbackTypeproperty toDashboardFieldTargetto infer filter types when fields/columns aren't available