8000 fix: Add ErrorBoundary to AssistantBubble component by notgiorgi · Pull Request #15367 · lightdash/lightdash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Add ErrorBoundary to AssistantBubble component #15367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

notgiorgi
Copy link
Contributor
@notgiorgi notgiorgi commented Jun 16, 2025

Description:

Added an ErrorBoundary component around the AssistantBubble in the AgentChatDisplay component to prevent the entire chat interface from crashing if there's an error rendering an assistant message.

< 8000 svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit">
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@notgiorgi notgiorgi changed the title chore: wrap component into an fix: Add ErrorBoundary to AssistantBubble component Jun 16, 2025
@notgiorgi notgiorgi marked this pull request as ready for review June 16, 2025 12:43
@notgiorgi notgiorgi requested a review from tatianainama June 16, 2025 12:46
Copy link

Your preview environment pr-15367 has been deployed.

Preview environment endpoints are available at:

Copy link

Comment on lines +23 to +25
<ErrorBoundary>
<AssistantBubble message={message} isPreview={isPreview} />
</ErrorBoundary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we wrap this whole component with the error boundary? so we can gracefully catch user bubble issues too

Copy link
Contributor Author
notgiorgi commented Jun 16, 2025

Merge activity

  • Jun 16, 12:53 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 16, 12:53 PM UTC: @notgiorg 8000 i merged this pull request with Graphite.

@notgiorgi notgiorgi merged commit 6a21e43 into main Jun 16, 2025
31 of 35 checks passed
@notgiorgi notgiorgi deleted the 06-16-chore_wrap_component_into_an branch June 16, 2025 12:53
lightdash-bot pushed a commit that referenced this pull request Jun 16, 2025
## [0.1724.1](0.1724.0...0.1724.1) (2025-06-16)

### Bug Fixes

* Add ErrorBoundary to AssistantBubble component ([#15367](#15367)) ([6a21e43](6a21e43))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1724.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
sentry-io bot commented Jun 22, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0