cmake: fix building in debug mode #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c63b142 to
d908d72
Compare
Buristan
approved these changes
Jul 3, 2025
77f2a4f to
42d145c
Compare
The build with -DCMAKE_BUILD_TYPE=Debug can ends with the error: > In file included from luzer/counters.c:8: > In file included from /usr/lib/llvm/20/bin/../../../../lib/clang/20/include/stdint.h:56: > In file included from /usr/include/stdint.h:26: > In file included from /usr/include/bits/libc-header-start.h:33: > /usr/include/features.h:422:4: error: _FORTIFY_SOURCE requires compiling with optimization (-O) [-Werror,-W#warnings] 422 | # warning _FORTIFY_SOURCE requires compiling with optimization (-O) This happened because optimizations must be enabled when compiler option `_FORTIFY_SOURCE` is enabled. CMake has four build types: Release, Debug, RelWithDebInfo, MinSizeRel and only Debug build type disables optimizations. The patch applies compiler hardening flags to all targets, enables `_FORTIFY_SOURCE` option only for non-debug builds and fixes errors generated by enabled compiler options. Fixes #54
42d145c to
08666ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build with -DCMAKE_BUILD_TYPE=Debug can ends with the error:
This happened because _FORTIFY_SOURCE should be enabled along with non-zero optimization level. CMake has four build types: Release, Debug, RelWithDebInfo, MinSizeRel and only Debug build type disables optimizations. The patch applies C compiler hardening flags to all targets, enables
_FORTIFY_SOURCEflags only for non-debug builds and fixes an error due to incorrect function prototype forget_global_lua_state().Fixes #54