feat: tests for "Latests rewards distribution" section on Dashboard #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview stand statusPreview stand available on testnet |
itaven
reviewed
Jun 20, 2025
| import { test } from '@playwright/test'; | ||
| import { contractClients } from 'tests/services/clients.contract'; | ||
|
|
||
| export const getReportFrameForLastRewards = async () => { |
itaven
reviewed
Jun 20, 2025
| .getByText('View on Etherscan') | ||
| .click(), | ||
| ]); | ||
| expect(etherscanPage.url()).toContain(`.etherscan.io`); |
There was a problem hiding this comment.
I believe it's possible to verify latest tx id to verify full url to compare freshnes of tx'l link
itaven
reviewed
Jun 20, 2025
| `Expected`, | ||
| ); | ||
| await expect(latestRewardsDistribution.expectedDays).toContainText( | ||
| `in ${expectedDays} day`, |
There was a problem hiding this comment.
As i see value able to be "Today". Maybe "Tomorrow. Can be flaky
exromany
requested changes
Jun 20, 2025
| @@ -93,7 +93,6 @@ | |||
| "@nestjs/common": "^10.4.16", | |||
| "@next/bundle-analyzer": "^13.2.4", | |||
| "@next/eslint-plugin-next": "^13.4.13", | |||
| "@playwright/test": "^1.51.1", | |||
| @@ -44,7 +44,7 @@ | |||
| } | |||
| ], | |||
| "import/no-extraneous-dependencies": [ | |||
| "error", | |||
| "off", | |||
jake4take
reviewed
Jun 20, 2025
| .getByText('View on Etherscan') | ||
| .click(), | ||
| ]); | ||
| expect(etherscanPage.url()).toContain(`.etherscan.io`); |
There was a problem hiding this comment.
The dot in the start can fail with the testrun on prod environment (.etherscan.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
✅ What’s new
waitForCallbackto helper (was inBasePage) — no direct page dependency anymoreRelated Issue
How Has This Been Tested?
Checklist