8000 Use modified date of extension file instead of version entry in json by dodmi · Pull Request #442 · lieser/dkim_verifier · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use modified date of extension file instead of version entry in json #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2024
Merged

Use modified date of extension file instead of version entry in json #442

merged 3 commits into from
Apr 28, 2024

Conversation

dodmi
Copy link
Contributor
@dodmi dodmi commented Apr 28, 2024

Increasing version number in signersDefault.json is a thing, I often forget.
I changed the detection behavior: The version in the json is replaced by checking the timestamp of the extension file in the current profile.

lieser
lieser requested changes Apr 28, 2024
View reviewed changes
Copy link
Owner
@lieser lieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with removing the version and replacing it with a time stamp instead.
But please also remove the now unused versionData from both data/signersDefault-schema.json and data/signersDefault.json.

@lieser lieser added this to the 2.3.0 milestone Apr 28, 2024
lieser
lieser requested changes Apr 28, 2024
View reviewed changes
@lieser lieser merged commit d25e245 into lieser:2.x Apr 28, 2024
2 checks passed
@dodmi dodmi deleted the add-2x-alternative-check-for-sign-rules-version-2024-04-28 branch April 28, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lieser lieser lieser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dodmi @lieser
0