8000 test: Improve flaky reboot instance test; Implement retry for execute test command function by ykim-akamai · Pull Request #676 · linode/linode-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: Improve flaky reboot instance test; Implement retry for execute test command function #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

ykim-akamai
Copy link
Contributor

📝 Description

test_reboot_linode test has been failing intermittently quiet often. This PR implements some wait conditions and retry function to hopefully stabilize the test.

✔️ How to Test

make TEST_CASE="test_reboot_linode" testint

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai added the testing for updates to the testing suite in the changelog. label Nov 6, 2024
@ykim-akamai ykim-akamai requested a review from a team as a code owner November 6, 2024 16:57
@ykim-akamai ykim-akamai requested review from yec-akamai and ezilber-akamai and removed request for a team November 6, 2024 16:57
@ykim-akamai
Copy link
Contributor Author
ykim-akamai commented Nov 6, 2024

Got a green build :) - https://github.com/linode/linode-cli/actions/runs/11708470979/job/32610300300

Copy link
Contributor
@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed locally! A few small suggestions:

Copy link
Contributor
@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing locally!

@ykim-akamai ykim-akamai merged commit 590d99a into linode:dev Nov 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0