Replace lstrip with substring to resolve #685 #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I took the liberty of opening up a PR myself as it is only a small fix. I hope the integration test is up to spec as I'm not a day to day python developer. |
yec-akamai
approved these changes
Dec 6, 2024
a823ae9 to
6575720
Compare
|
Thank you for your contribution! We will merge it after bumping the Python version because See #698 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR fixes the issue described in #685.
It replaces the existing
lstripcall to extract the object prefix with a substring based on the length of the bucket name.✔️ How to Test
Tested full objects module and new test case which tries to reproduce the case described in #685.
make MODULE=obj testintmake MODULE=obj TEST_CASE=test_obj_single_file_single_bucket_with_prefix_ltrim testint