8000 Alphabetize config by mssalvatore · Pull Request #704 · linode/linode-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Alphabetize config #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2025
Merged

Alphabetize config #704

merged 4 commits into from
Jan 10, 2025

Conversation

mssalvatore
Copy link
Contributor

📝 Description

When configuring linode-cli, options are presented to the user in a random order. For example:

Select the user that should be given default SSH access to new Linodes.  Choices are:
1 - dour
2 - shiff
3 - retardment
4 - linotype
5 - subak
6 - frothy
7 - heptateuch
8 - sapp
9 - magisterial
10 - anglin
11 - fancied
12 - mercola
13 - naked
14 - aftershock
15 - spleen
16 - cuda
17 - carlinecarling
18 - natalienatalina
19 - whitehead
20 - rutherfordium
21 - sterrett
22 - integrated
23 - metacenter
24 - galegalea
25 - monachism
26 - turkish
27 - fabricate
28 - orvil
29 - rooker
30 - mintun
31 - prove

Default Option (Optional):

Have fun finding the user you're looking for!

This PR sorts the usernames to improve UX. It also sorts the regions, linode types, and images for the same reason.

✔️ How to Test

I tested by running linode-cli configure and verifying that the selected options appeared in the config file.

Since this PR does not introduce any new functionality, I did not add any tests. I did verify that these changes do not introduce failures when running unit tests.

📷 Preview

1
2
3
4

Note

I wasn't sure if the linode types had some strategic order. I did sort them, however, that commit (or any other) can easily be dropped if this isn't desirable.

@mssalvatore mssalvatore requested a review from a team as a code owner December 17, 2024 14:40
@mssalvatore mssalvatore requested review from jriddle-linode and zliang-akamai and removed request for a team December 17, 2024 14:40
@zliang-akamai
Copy link
Member

Can you do a make format to format everything and makes the linter happy?

@mssalvatore
Copy link
Contributor Author

Can you do a make format to format everything and makes the linter happy?

Done!

jriddle-linode
jriddle-linode approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator
@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally thank you!

@zliang-akamai zliang-akamai merged commit a8c94e2 into linode:dev Jan 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jriddle-linode jriddle-linode jriddle-linode approved these changes

@zliang-akamai zliang-akamai zliang-akamai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mssalvatore @zliang-akamai @jriddle-linode
0