lindb · stone1100 · Mar 28, 2023 · Mar 27, 2023
diff --git a/aggregation/series_agg.go b/aggregation/series_agg.go
@@ -18,7 +18,6 @@
 package aggregation
 
 import (
-	"fmt"
 	"sync"
 
 	"github.com/lindb/lindb/pkg/timeutil"
@@ -165,7 +164,6 @@ func (a *seriesAggregator) Reset() {
 
 // GetAggregates returns all field aggregators.
 func (a *seriesAggregator) GetAggregates() []FieldAggregator {
-	fmt.Println(a.aggregates)
 	return a.aggregates
 }
 

diff --git a/pkg/option/tsdb.go b/pkg/option/tsdb.go
@@ -45,6 +45,21 @@ func (m Intervals) String() string {
 	return fmt.Sprintf("[%s]", strings.Join(rs, ","))
 }
 
+// IsValid checks if intervals is valid, if invalid return error.
+func (m Intervals) IsValid() error {
+	intervalMap := make(map[timeutil.IntervalType]Interval)
+	for _, i := range m {
+		intervalType := i.Interval.Type()
+		exist, ok := intervalMap[intervalType]
+		if ok {
+			return fmt.Errorf("duplicate interval type,[%s(%s),%s(%s)]",
+				exist.String(), intervalType.String(), i.String(), intervalType.String())
+		}
+		intervalMap[intervalType] = i
+	}
+	return nil
+}
+
 // Interval represents the database's interval option, include interval and data retention.
 type Interval struct {
 	Interval  timeutil.Interval `toml:"interval" json:"interval,omitempty" validate:"required"`
@@ -108,6 +123,9 @@ func (e *DatabaseOption) Validate() error {
 	if len(e.Intervals) == 0 {
 		return errors.New("intervals cannot be empty")
 	}
+	if err := e.Intervals.IsValid(); err != nil {
+		return err
+	}
 	// TODO: need remove
 	if err := validateInterval(e.Ahead, false); err != nil {
 		return err

diff --git a/pkg/option/tsdb_test.go b/pkg/option/tsdb_test.go
@@ -53,6 +53,14 @@ func TestDatabaseOption_Validate(t *testing.T) {
 			DatabaseOption{Intervals: Intervals{{}}, Behind: "0h"},
 			true,
 		},
+		{
+			"validation pass",
+			DatabaseOption{Intervals: Intervals{
+				{timeutil.Interval(timeutil.OneSecond), timeutil.Interval(timeutil.OneMonth)},
+				{timeutil.Interval(timeutil.OneMinute), timeutil.Interval(timeutil.OneMonth)},
+			}, Behind: "1h", Ahead: "1h"},
+			true,
+		},
 		{
 			"validation pass",
 			DatabaseOption{Intervals: Intervals{{}}, Behind: "1h", Ahead: "1h"},
@@ -147,6 +155,21 @@ func TestIntervals_Sort(t *testing.T) {
 	assert.Equal(t, "[1s->1M,1m->1M,1h->1M]", intervals.String())
 }

+func TestIntervals_IsValid(t *testing.T) {
+	intervals := Intervals{
+		{timeutil.Interval(timeutil.OneSecond), timeutil.Interval(timeutil.OneMonth)},
+		{timeutil.Interval(timeutil.OneMinute), timeutil.Interval(timeutil.OneMonth)},
+		{timeutil.Interval(timeutil.OneHour), timeutil.Interval(timeutil.OneMonth)},
+	}
+	assert.Error(t, intervals.IsValid())
+	intervals = Intervals{
+		{timeutil.Interval(timeutil.OneSecond), timeutil.Interval(timeutil.OneMonth)},
+		{timeutil.Interval(timeutil.OneMinute * 5), timeutil.Interval(timeutil.OneMonth)},
+		{timeutil.Interval(timeutil.OneHour), timeutil.Interval(timeutil.OneMonth)},
+	}
+	assert.NoError(t, intervals.IsValid())
+}
+
 func TestDatabaseOption_FindMatchSmallestInterval(t *testing.T) {
 	opt := DatabaseOption{Intervals: Intervals{
 		{timeutil.Interval(timeutil.OneSecond), timeutil.Interval(timeutil.OneMonth)},