8000 [bug:#994]: fix not in statement returns an empty result by joyant · Pull Request #996 · lindb/lindb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[bug:#994]: fix not in statement returns an empty result #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

joyant
Copy link
Contributor
@joyant joyant commented Dec 1, 2023

What problem does this PR solve?

Issue Number: #994

Problem Summary:
Fixing the issue where the NOT IN statement returns an empty result when the tag value does not exist.

Check List

Tests

  • Unit test
  • Integration test
  • No code

Copy link
codecov bot commented Dec 1, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2d5b7ec) 96.24% compared to head (200c0a9) 96.23%.

Files Patch % Lines
query/operator/tag_values_lookup.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
- Coverage   96.24%   96.23%   -0.01%     
==========================================
  Files         405      405              
  Lines       24912    24913       +1     
==========================================
- Hits        23977    23976       -1     
- Misses        663      664       +1     
- Partials      272      273       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joyant joyant changed the title [bug:#994]: fix not in statement returns an empty result [bug]: fix not in statement returns an empty result(#994) Dec 1, 2023
@joyant joyant changed the title [bug]: fix not in statement returns an empty result(#994) [bug:#994]: fix not in statement returns an empty result Dec 1, 2023
@stone1100 stone1100 merged commit d4b8b22 into lindb:main Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0