8000 Semi-transparency cleanup and clear rework by Ciantic · Pull Request #1617 · linebender/druid · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Semi-transparency cleanup and clear rework #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2021
Merged

Semi-transparency cleanup and clear rework #1617

merged 3 commits into from
Mar 31, 2021

Conversation

Ciantic
Copy link
Collaborator
@Ciantic Ciantic commented Feb 23, 2021 •
edited
Loading

Primary purpose of this PR is to update window do_paint to use the clear instead of fill. The clear works for both transparent and opaque colors. Secondarily this PR cleans unnecessary code from Windows side of things.

Changes include a minor change to transparency.rs, with textbox and label added, so one can test the invalidation more easily just by typing to textbox:

@cmyr cmyr added the S-blocked waits for another PR or dependency label Mar 5, 2021
@cmyr cmyr added this to the piet-4.0 milestone Mar 18, 2021
@cmyr cmyr removed the S-blocked waits for another PR or dependency label Mar 30, 2021
@cmyr
Copy link
Member
cmyr commented Mar 30, 2021

@Ciantic you should be able to revisit this now?

@Ciantic
Copy link
Collaborator Author
Ciantic commented Mar 30, 2021

@cmyr great! Piet and Kurbo seems to have now updated. I will do necessary changes to get this working.

@Ciantic Ciantic requested a review from cmyr March 30, 2021 18:55
@Ciantic
Copy link
Collaborator Author
Ciantic commented Mar 30, 2021

All green. 🟢

@Ciantic Ciantic marked this pull request as ready for review March 31, 2021 16:12
cmyr
cmyr approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member
@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ciantic Ciantic merged commit 2ceecaf into linebender:master Mar 31, 2021
richard-uk1 pushed a commit to richard-uk1/druid that referenced this pull request Apr 6, 2021
@Ciantic @richard-uk1
Semi-transparency cleanup and clear rework (linebender#1617)
c7fb115 
Semi-transparency cleanup
matthewgapp added a commit to matthewgapp/druid that referenced this pull request Jun 3, 2023
@matthewgapp
partially "reverting" PR linebender#1617
7a0de18
@matthewgapp matthewgapp mentioned this pull request Jun 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
piet-4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Ciantic @cmyr
0