8000 Correct the capitalisation of the `png ` tag by DJMcNab · Pull Request #740 · linebender/vello · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Correct the capitalisation of the png tag #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Correct the capitalisation of the png tag #740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vello/src/scene/bitmap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ impl<'a> BitmapStrike<'a> {
match &self.0 {
StrikeKind::Sbix(sbix, metrics) => {
let glyph = sbix.glyph_data(glyph_id).ok()??;
if glyph.graphic_type() != Tag::new(b"PNG ") {
if glyph.graphic_type() != Tag::new(b"png ") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to note some provenance for this tag. Perhaps https: 8ACA //developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6sbix.html

Copy link
Member Author
@DJMcNab DJMcNab Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The canonical form of this code doesn't live here; I've intentionally touched it as little as possible. Instead, it can be found at https://github.com/googlefonts/fontations/blob/skrifa-bitmaps/skrifa/src/bitmap.rs.

The place to record this feedback is probably in the first linked issue in the PR.

return None;
}
let glyf_bb = metrics.bounds(glyph_id).unwrap_or_default();
Expand Down
0