-
Notifications
You must be signed in to change notification settings - Fork 164
Fix COLRv1 for Segoe UI Emoji #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The yx and xy transform components were swapped in the conversion. Also the repeat/reflect extend modes.
nicoburns
approved these changes
Mar 9, 2025
Also appears to fix #669 :) |
This was
linked to
issues
Mar 9, 2025
nicoburns
pushe
8000
d a commit
that referenced
this pull request
Mar 9, 2025
The yx and xy transform components were swapped in the conversion. Also the repeat/reflect extend modes. See zulip: https://xi.zulipchat.com/#narrow/channel/205635-text/topic/Purple.20emoji.20on.20Windows/with/503831553
DJMcNab
pushed a commit
that referenced
this pull request
Mar 10, 2025
The yx and xy transform components were swapped in the conversion. Also the repeat/reflect extend modes. See zulip: https://xi.zulipchat.com/#narrow/channel/205635-text/topic/Purple.20emoji.20on.20Windows/with/503831553
DJMcNab
added a commit
that referenced
this pull request
Mar 10, 2025
See [#gpu > Vello 0.4.1 release](https://xi.zulipchat.com/#narrow/channel/197075-gpu/topic/Vello.200.2E4.2E1.20release) This release is to backport #841 --------- Signed-off-by: Nico Burns <nico@nicoburns.com> Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
See [#gpu > Vello 0.4.1 release](https://xi.zulipchat.com/#narrow/channel/197075-gpu/topic/Vello.200.2E4.2E1.20release) This release is to backport #841 --------- Signed-off-by: Nico Burns <nico@nicoburns.com> Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
Merged
DJMcNab
pushed a commit
that referenced
this pull request
Mar 10, 2025
The yx and xy transform components were swapped in the conversion. Also the repeat/reflect extend modes. See zulip: https://xi.zulipchat.com/#narrow/channel/205635-text/topic/Purple.20emoji.20on.20Windows/with/503831553
DJMcNab
added a commit
that referenced
this pull request
Mar 10, 2025
See [#gpu > Vello 0.4.1 release](https://xi.zulipchat.com/#narrow/channel/197075-gpu/topic/Vello.200.2E4.2E1.20release) This release is to backport #841 --------- Signed-off-by: Nico Burns <nico@nicoburns.com> Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The yx and xy transform components were swapped in the conversion. Also the repeat/reflect extend modes.
See zulip: https://xi.zulipchat.com/#narrow/channel/205635-text/topic/Purple.20emoji.20on.20Windows/with/503831553