feat(tracing): Allow trace collector to be unmeshed #3953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy currently treats the trace collector endpoint as a control plane component, mostly to prevent a circular dependency in the service stack. This means that we've had to manually supply a mesh identity in the form of a service account name, usually through an extension's injector. However, this isn't strictly required as the control plane stack works just fine when the endpoint is unmeshed. This is realistically only useful for the trace collector which don't benefit much from being meshed, so this change only allows the collector to omit a mesh identity. Signed-off-by: Scott Fleener <scott@buoyant.io>
20e4322 to
7343c72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy currently treats the trace collector endpoint as a control plane component, mostly to prevent a circular dependency in the service stack. This means that we've had to manually supply a mesh identity in the form of a service account name, usually through an extension's injector.
However, this isn't strictly required as the control plane stack works just fine when the endpoint is unmeshed. This is realistically only useful for the trace collector which don't benefit much from being meshed, so this change only allows the collector to omit a mesh identity.