8000 Remove empty `shortnames` from ExternalWorkload by siggy · Pull Request #12793 · linkerd/linkerd2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove empty shortnames from ExternalWorkload #12793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2024
Merged

Remove empty shortnames from ExternalWorkload #12793

merged 1 commit into from
Jul 1, 2024

Conversation

siggy
Copy link
Member
@siggy siggy commented Jul 1, 2024

The shortnames: [] field on the ExternalWorkload CRD causes tools like ArgoCD to report applications out of sync.

Remove the empty field completely from the CRD manifest.

@siggy
Remove empty shortnames from ExternalWorkload
2de5a5b 
The `shortnames: []` field on the `ExternalWorkload` CRD causes tools
like ArgoCD to report applications out of sync.

Remove the empty field completely from the CRD manifest.

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
@siggy siggy self-assigned this Jul 1, 2024
@siggy siggy requested a review from a team as a code owner July 1, 2024 18:05
@olix0r olix0r merged commit 0719b11 into main Jul 1, 2024
37 checks passed
@olix0r olix0r deleted the siggy/no-shortnames branch July 1, 2024 18:36
alpeb added a commit that referenced this pull request Nov 10, 2024
@alpeb
Remove empty shortnames: [] from HTTPLocalRateLimitPolicy
12effd6 
ArgoCD is not compatible with an empty `shortnames` entry.
(We encountered this same issue in the past with ExternalWorkloads: #12793)

Fixes #13295
@alpeb alpeb mentioned this pull request Nov 10, 2024
Merged
olix0r pushed a commit that referenced this pull request Nov 11, 2024
@alpeb
Remove empty shortnames: [] from HTTPLocalRateLimitPolicy (#13297)
a6057bb 
ArgoCD is not compatible with an empty `shortnames` entry.
(We encountered this same issue in the past with ExternalWorkloads: #12793)

Fixes #13295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olix0r olix0r olix0r approved these changes

Assignees

@siggy siggy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siggy @olix0r
0