Allow configuring externalTrafficPolicy #13016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpeb
reviewed
Sep 4, 2024
multicluster/charts/linkerd-multicluster/templates/gateway.yaml
Outdated
Show resolved
Hide resolved
adleong
approved these changes
Sep 6, 2024
The linkerd-multicluster helm chart does not allow changing the externalTrafficPolicy of the linkerd-gateway Service Add serviceExternalTrafficPolicy to allow changing the value in the deployed service if needed. Deploying the linkerd-multicluster chart with "serviceExternalTrafficPolicy: Local" will make the Service to be deployed with `externalTrafficPolicy: Local` Fixes linkerd#13015 Signed-off-by: Lauri Kuittinen <lauriku@gmail.com>
8d5d6f3 to
0938c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linkerd-multicluster helm chart does not allow changing the
externalTrafficPolicyof thelinkerd-gatewayServiceAdd
serviceExternalTrafficPolicyto allow changing the value in the deployed service if needed.Deploying the linkerd-multicluster chart with
serviceExternalTrafficPolicy: Localwill make the Service to be deployed withexternalTrafficPolicy: LocalFixes #13015
Signed-off-by: Lauri Kuittinen lauriku@gmail.com