8000 chore(deps): sort and organize dependencies by cratelyn · Pull Request #13969 · linkerd/linkerd2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(deps): sort and organize dependencies #13969

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cratelyn
Copy link
Contributor

this commit tends to our package manifests.

dependencies are sorted, and dependencies whose metadata are longer than 80 characters are tweaked to be declared as tables. local dependencies a 8000 re updated to consistently follow the convention that they be listed after other external crates.io dependencies.

@cratelyn cratelyn marked this pull request as ready for review April 25, 2025 16:04
@cratelyn cratelyn requested a review from a team as a code owner April 25, 2025 16:04
Copy link
Member
@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Any idea if some of these conventions are enforceable via some kind of linter?

@cratelyn
Copy link
Contributor Author
cratelyn commented May 6, 2025

Nice! Any idea if some of these conventions are enforceable via some kind of linter?

unfortunately there is not a widely-adopted linter that i know of.

this commit tends to our package manifests.

dependencies are sorted, and dependencies whose metadata are longer than
80 characters are tweaked to be declared as tables. local dependencies
are updated to consistently follow the convention that they be listed
after other external crates.io dependencies.

Signed-off-by: katelyn martin <kate@buoyant.io>
@cratelyn cratelyn force-pushed the kate/policy-controller.nit-manifests branch from cdd0cff to 4bb5023 Compare May 6, 2025 14:47
@cratelyn
Copy link
Contributor Author
cratelyn commented May 6, 2025

i have rebased this commit to sit atop the latest main, addressing conflicts that had arisen in policy-controller/k8s/status/Cargo.toml. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.
0