feat(tracing): Add proxy tracing configuration to control plane helm chart #13994
Conversation
IIUC, this should be followed up as well by parametrizing the deployment of the injector in linkerd-jaeger, disabling it by default? |
…chart Previously, this would require the `linkerd-jaeger` extension to be installed. This comes with its own set of issues, namely managing yet another component of linkerd. Since the tracing config is basically just environment variables and one volume mount, hoisting them up into the main control plane helm chart for the proxy injector to handle is likely the simplest and most maintainable path going forward. The injector from the `linkerd-jaeger` extension will still work for the time being, and is interoprable to some degree as long as the injector in the extension is disabled. A follow-up to this PR should add documentation around this and how users can migrate from the extension to these configs. Signed-off-by: Scott Fleener <scott@buoyant.io>
62c78bc to
812c616
Compare
| # -- Protocol to export traces with. Currently supported are | ||
| # "opentelemetry" (default) and "opencensus" (deprecated) | ||
| protocol: opentelemetry |
There was a problem hiding this comment.
Given that this is new configuration, why support the deprecated value here? I would omit the field from values.yaml for now and rely on defaulting in the template.
| endpoint: "" | ||
| # -- The identity of the collector in the linkerd mesh. If the collector | ||
| # is unmeshed (recommended), this should remain unset. | ||
| meshIdentity: "" |
There was a problem hiding this comment.
I think "identity" is ambiguous here. It's not actually an identity string. Is this the serviceAccountName?
Perhaps:
meshIdentity:
serviceAccountName: collector
| # -- The collector endpoint to send traces to. | ||
| endpoint: "" | ||
| # -- The identity of the collector in the linkerd mesh. If the collector | ||
| # is unmeshed (recommended), this should remain unset. |
There was a problem hiding this comment.
I don't think we should recommend unmeshed configurations without clearly stipulating that this is not encrypted, etc...
Previously, this would require the
linkerd-jaegerextension to be installed. This comes with its own set of issues, namely managing yet another component of linkerd.Since the tracing config is basically just environment variables and one volume mount, hoisting them up into the main control plane helm chart for the proxy injector to handle is likely the simplest and most maintainable path going forward.
The injector from the
linkerd-jaegerextension will still work for the time being, and is interoprable to some degree as long as the injector in the extension is disabled. A follow-up to this PR should add documentation around this and how users can migrate from the extension to these configs.