8000 refactor(proxy-injector): make injection code take a value overrider as a parameter by adleong · Pull Request #14037 · linkerd/linkerd2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(proxy-injector): make injection code take a value overrider as a parameter #14037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

refactor(proxy-injector): make injection code take a value overrider as a parameter #14037

merged 1 commit into from
May 23, 2025

Conversation

adleong
Copy link
Member
@adleong adleong commented May 20, 2025

In order to make the way that proxy injector patches more flexible, we adjust the method signature of ResourceConfig.GetPodPatch to accept a ValueOverrider. The type of ValueOverrider is:

func(values *l5dcharts.Values, overrides map[string]string, namedPorts map[string]int32) (*l5dcharts.Values, error)

and specifies how overrides (in the form of pod and namespace annotations) get translated into values for the proxy patch template.

The current override behavior, specified in GetOverriddenValues, is supplied in all cases, making this a refactor with no functional changes.

@adleong
make injection code take a value overrider as a parameter
b7397c4 
Signed-off-by: Alex Leong <alex@buoyant.io>
@adleong adleong requested a review from a team as a code owner May 20, 2025 23:05
alpeb
alpeb approved these changes May 23, 2025
View reviewed changes
Copy link
Member
@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adleong adleong merged commit db495d6 into main May 23, 2025
40 checks passed
@adleong adleong deleted the alex/inject-overrider branch May 23, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpeb alpeb alpeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adleong @alpeb
0