fix(test): fix policy-test e2e_appprotocol #14148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<
8000
div data-view-component="true" class="TimelineItem-body">
Due to curl/curl#17554 curl is not returning an error code on a failed call that was invoked with the `--retry` flag. We temporarily revert to curl `v8.13.0` until the fix gets released.
adleong
approved these changes
Jun 17, 2025
Comment on lines
+30
to
+32
| // @TODO(alpeb): point to `latest` once the fix for this bug is released: | ||
| // https://github.com/curl/curl/issues/17554 | ||
| const CURL_IMAGE: &'static str = "docker.io/curlimages/curl:8.13.0"; |
There was a problem hiding this comment.
counterpoint: I'd rather us pin to a specifically known good version of the curl image for reproducibility instead of floating on latest.
There was a problem hiding this comment.
Ideally we'd use renovate or some tool that can bump this automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to curl/curl#17554 curl is not returning an error code on a failed call that was invoked with the
--retryflag.We temporarily revert to curl
v8.13.0until the fix gets released.