fix(helm): Allow setting caBundle with caPEM and keyPEM #14109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting caPEM and keyPEM does not work as intended, as caBundle is set to the helm-generated self-signed CA. Setting caBundle does not work as externalSecret would need to be set, which counteracts caPEM and keyPEM. This allows setting caBundle without `externalSecret: true`, so that all three values (caPEM, keyPEM, caBundle) may be set in conjunction. Setting this for e.g. linkerd-viz tap: ```sh step certificate create tap.linkerd-viz.svc tap.crt tap.key \ --profile root-ca --no-password --insecure --san tap.linkerd-viz.svc linkerd viz install \ --set-file tap.keyPEM=ca.key \ --set-file tap.crtPEM=ca.crt \ --set-file tap.caBundle=ca.crt \ | kubectl apply -f - ``` found while investigating linkerd#14059 linkerd#13723 Signed-off-by: Jonas Dittrich <kakadus2303@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting caPEM and keyPEM does not work as intended, as caBundle is set to the helm-generated self-signed CA. Setting caBundle does not work as externalSecret would need to be set, which counteracts caPEM and keyPEM.
This allows setting caBundle without
externalSecret: true, so that all three values (caPEM, keyPEM, caBundle) may be set in conjunction.Setting this for e.g. linkerd-viz tap:
step certificate create tap.linkerd-viz.svc tap.crt tap.key \ --profile root-ca --no-password --insecure --san tap.linkerd-viz.svc linkerd viz install \ --set-file tap.keyPEM=ca.key \ --set-file tap.crtPEM=ca.crt \ --set-file tap.caBundle=ca.crt \ | kubectl apply -f -found while investigating #14059 #13723