fix test to be less rigid in formating issues to help push through li… #2597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2597 +/- ##
=======================================
Coverage 81.09% 81.09%
=======================================
Files 121 121
Lines 13479 13479
Branches 3786 3786
=======================================
Hits 10931 10931
Misses 1919 1919
Partials 629 629 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmungall
reviewed
Mar 31, 2025
| print(f"[INFO] {filename}: No exception raised (may be expected)") | ||
| except Exception as e: | ||
| # If exception raised, log it and optionally check message | ||
| print(f"[INFO] {filename}: Rai 8000 sed {type(e).__name__} -> {e}") |
cmungall
reviewed
Mar 31, 2025
| validate(instance, schema) | ||
| assert False, "Expected an exception due to invalid schema, but none was raised" | ||
| except Exception as e: | ||
| assert isinstance(e, Exception) |
There was a problem hiding this comment.
this is always true... but maybe ok to keep as a stub when new runtime release is out?
cmungall
approved these changes
Mar 31, 2025
| try: | ||
| YAMLGenerator(fn).serialize(validateonly=True) | ||
| print("[INFO] issue_326a.yaml: No exception raised") | ||
| except Exception as e: |
There was a problem hiding this comment.
Doing this makes these no longer tests - there is nothing asserted and they can't fail
There was a problem hiding this comment.
yes, it should have retained with pytest.raises but just with a more general Exception or union of exception types.... we can restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nkml-runtime release