8000 Add pre-commit to code quality check by vladistan · Pull Request #2744 · linkml/linkml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add pre-commit to code quality check #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add pre-commit to code quality check #2744

wants to merge 1 commit into from
+4 −4

Conversation

vladistan
Copy link
Contributor

No description provided.

@vladistan vladistan marked this pull request as draft June 2, 2025 23:45
@vladistan vladistan force-pushed the add-precommit-to-code-quality-check branch 3 times, most recently from 93f38a8 to 860a8e6 Compare June 9, 2025 20:12
dalito
dalito reviewed Jun 9, 2025
View reviewed changes
.github/workflows/main.yaml
@@ -31,6 +31,10 @@ jobs:
run: tox -e codespell
- name: Run code quality checks
run: tox -e lint
- name: Run pre-commit checks
Copy link
Member
@dalito dalito Jun 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since pre-commit runs codespell you could delete the lines above

      - name: Run code quality checks
        run: tox -e lint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, done

@vladistan vladistan force-pushed the add-precommit-to-code-quality-check branch 6 times, most recently from 27e84e7 to a655cd6 Compare June 11, 2025 20:03
@vladistan vladistan force-pushed the add-precommit-to-code-quality-check branch 2 times, most recently from a06df09 to ddbc13a Compare June 24, 2025 18:34
@vladistan vladistan force-pushed the add-precommit-to-code-quality-check branch 3 times, most recently from bf3b06e to 5558384 Compare July 1, 2025 23:34
@vladistan vladistan force-pushed the add-precommit-to-code-quality-check branch 8 times, most recently from 4f0622e to 4a7d8d0 Compare July 12, 2025 13:05
@Silvanoc
Copy link
Contributor

I use pre-commit in my other projects. I simply activate my local git pre-commit hooks and I known that I won't be pushing anything that'll be rejected by CI. I've shown some support for it in the past, but there was some opposition at that time. Happy to see it coming back 😄

@vladistan
Copy link
Contributor Author
vladistan commented Jul 15, 2025 via email

@vladistan vladistan force-pushed the add-precommit-to-code-quality-check branch from 4a7d8d0 to 416b9fb Compare July 16, 2025 00:27
@vladistan vladistan force-pushed the add-precommit-to-code-quality-check branch from 416b9fb to 3bb6f34 Compare July 16, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalito dalito dalito left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladistan @Silvanoc @dalito
0